feat: robust error handling and type safety

Add type-safe error helpers and remove 'as any' casts.

Changes:
- Add isAbortError() helper for checking abort signals
- Add getEventDetail() helper for CustomEvent extraction
- Fix variable naming in isRetryable() (isAborted vs isAbortError)
- Use proper instanceof checks instead of casting
- Add proper interface for normalized response data
- Type-safe tool execution error messages
This commit is contained in:
linked-danis
2026-03-12 14:07:45 +01:00
parent 734ec47d0b
commit f45f9d020e
5 changed files with 79 additions and 22 deletions
+28 -12
View File
@@ -20,7 +20,15 @@ import type {
MacroToolInput,
MacroToolResult,
} from './types'
import { assert, fetchLlmsTxt, normalizeResponse, uid, waitFor } from './utils'
import {
assert,
fetchLlmsTxt,
getEventDetail,
isAbortError,
normalizeResponse,
uid,
waitFor,
} from './utils'
export { tool, type PageAgentTool } from './tools'
export type * from './types'
@@ -104,27 +112,35 @@ export class PageAgentCore extends EventTarget {
// Listen to LLM retry events
this.#llm.addEventListener('retry', (e) => {
const { attempt, maxAttempts } = (e as CustomEvent).detail
this.#emitActivity({ type: 'retrying', attempt, maxAttempts })
const detail = getEventDetail<{ attempt: number; maxAttempts: number }>(e)
if (!detail) return
this.#emitActivity({
type: 'retrying',
attempt: detail.attempt,
maxAttempts: detail.maxAttempts,
})
// Also push to history for panel rendering
this.history.push({
type: 'retry',
message: `LLM retry attempt ${attempt} of ${maxAttempts}`,
attempt,
maxAttempts,
message: `LLM retry attempt ${detail.attempt} of ${detail.maxAttempts}`,
attempt: detail.attempt,
maxAttempts: detail.maxAttempts,
})
this.#emitHistoryChange()
})
this.#llm.addEventListener('error', (e) => {
const error = (e as CustomEvent).detail.error as Error | InvokeError
if ((error as any)?.rawError?.name === 'AbortError') return
const message = String(error)
const detail = getEventDetail<{ error: unknown }>(e)
if (!detail) return
const error = detail.error
if (isAbortError(error)) return
const message = error instanceof Error ? error.message : String(error)
this.#emitActivity({ type: 'error', message })
// Also push to history for panel rendering
this.history.push({
type: 'error',
message,
rawResponse: (error as InvokeError).rawResponse,
rawResponse:
error instanceof Error ? (error as InvokeError).rawResponse : undefined,
})
this.#emitHistoryChange()
})
@@ -314,10 +330,10 @@ export class PageAgentCore extends EventTarget {
}
} catch (error: unknown) {
console.groupEnd() // to prevent nested groups
const isAbortError = (error as any)?.rawError?.name === 'AbortError'
const isAborted = isAbortError(error)
console.error('Task failed', error)
const errorMessage = isAbortError ? 'Task stopped' : String(error)
const errorMessage = isAborted ? 'Task stopped' : String(error)
this.#emitActivity({ type: 'error', message: errorMessage })
this.history.push({ type: 'error', message: errorMessage, rawResponse: error })
this.#emitHistoryChange()
+27
View File
@@ -101,3 +101,30 @@ export function assert(condition: unknown, message?: string, silent?: boolean):
throw new Error(errorMessage)
}
}
/**
* Check if an error is an AbortError (from AbortController)
* Handles various forms: Error with name 'AbortError', or rawError property
*/
export function isAbortError(error: unknown): boolean {
if (error instanceof Error && error.name === 'AbortError') return true
if (
typeof error === 'object' &&
error !== null &&
'rawError' in error &&
(error as { rawError?: Error }).rawError?.name === 'AbortError'
)
return true
return false
}
/**
* Safely extract detail from CustomEvent
* @returns The detail object or null if not a CustomEvent
*/
export function getEventDetail<T>(event: Event): T | null {
if (event instanceof CustomEvent) {
return event.detail as T
}
return null
}