0xallam
d8881498ee
The SDK harness is the only path now; legacy host-side code is gone. File names no longer carry the ``sdk_`` distinction. Deleted legacy host-side modules: - strix/agents/StrixAgent/ (template moved to strix/agents/prompts/) - strix/agents/base_agent.py, state.py - strix/llm/llm.py, config.py - strix/runtime/docker_runtime.py, runtime.py - strix/tools/executor.py, agents_graph/agents_graph_actions.py - strix/interface/sdk_dispatch.py + the env-flag dispatch in cli.py Renamed (drop ``sdk_`` prefix): - strix/sdk_entry.py → strix/entry.py - strix/agents/sdk_factory.py → strix/agents/factory.py - strix/agents/sdk_prompt.py → strix/agents/prompt.py - strix/tools/<x>/<x>_sdk_tool[s].py → strix/tools/<x>/tool[s].py - strix/tools/_legacy_adapter.py → strix/tools/_state_adapter.py - ``_legacy`` aliases inside the wrappers → ``_impl`` CLI + TUI now call ``run_strix_scan`` directly — they build the sandbox image / sources_path locally and rely on ``session_manager.cleanup`` (called inside ``run_strix_scan``'s finally) for teardown. Three TUI handlers that reached into legacy multi-agent globals (``_agent_instances``, ``send_user_message_to_agent``, ``stop_agent``) are now no-ops with a TODO; reconnecting them to the ``AgentMessageBus`` is a follow-up. Tracer.get_total_llm_stats no longer reaches into the deleted ``agents_graph_actions`` globals — the orchestration hooks now feed the tracer via ``Tracer.record_llm_usage`` (live + completed buckets). finish_scan's ``_check_active_agents`` and load_skill's runtime ``_agent_instances`` reach-in are no-op stubs; the ``AgentMessageBus`` is the source of truth post-migration. llm/utils.py rewritten to keep only the streaming-parser helpers (``normalize_tool_format``, ``parse_tool_invocations``, ``fix_incomplete_tool_call``, ``format_tool_call``, ``clean_content``). ``STRIX_MODEL_MAP`` moved to ``llm/multi_provider_setup.py`` (its only remaining caller). Per-file ruff ignores added for legacy interface modules (TUI / main / CLI / utils / streaming_parser / tool_components) and tracer.py — pre-existing PLC0415/BLE001/PLR0915 patterns are out of scope. Tests: 287/287 passing. Renamed test files to drop ``sdk_`` prefix. ``test_tracer.py::test_get_total_llm_stats_aggregates_live_and_completed`` rewritten to feed ``Tracer.record_llm_usage`` instead of legacy globals. Test file annotations added so pre-commit's strict mypy passes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
68 lines
2.2 KiB
Python
68 lines
2.2 KiB
Python
"""SDK function-tool wrapper for the legacy ``finish_scan`` tool.
|
|
|
|
The legacy function:
|
|
|
|
- Validates the caller is the root agent (``parent_id is None``).
|
|
- Checks no other agents are still running (via the legacy
|
|
``_agent_graph`` global).
|
|
- Persists the four executive-summary fields via
|
|
``get_global_tracer().update_scan_final_fields(...)``.
|
|
- Reports the final vulnerability count.
|
|
|
|
Both the parent-id check and the agent-graph check rely on legacy
|
|
multi-agent state that Phase 3 will reimplement on top of the SDK
|
|
``RunContextWrapper`` + a per-run registry. Until Phase 3 lands, the
|
|
legacy adapter returns an object with no ``parent_id`` attribute —
|
|
``hasattr`` returns False, the validation skips, and the call proceeds
|
|
as if invoked by a root agent. That's the correct degenerate behavior
|
|
in single-agent mode, which is all Phase 2 ships.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import json
|
|
from typing import Any
|
|
|
|
from agents import RunContextWrapper
|
|
|
|
from strix.tools._decorator import strix_tool
|
|
from strix.tools._state_adapter import adapter_from_ctx
|
|
from strix.tools.finish import finish_actions as _impl
|
|
|
|
|
|
def _dump(result: dict[str, Any]) -> str:
|
|
return json.dumps(result, ensure_ascii=False, default=str)
|
|
|
|
|
|
@strix_tool(timeout=60)
|
|
async def finish_scan(
|
|
ctx: RunContextWrapper,
|
|
executive_summary: str,
|
|
methodology: str,
|
|
technical_analysis: str,
|
|
recommendations: str,
|
|
) -> str:
|
|
"""Finalize the scan and persist the four executive summary sections.
|
|
|
|
Only the root agent should call this. Subagents should use
|
|
``agent_finish`` from the agents_graph tool family instead.
|
|
|
|
Args:
|
|
executive_summary: High-level scan outcome.
|
|
methodology: Approach taken.
|
|
technical_analysis: Findings detail across the engagement.
|
|
recommendations: Prioritized fix list.
|
|
"""
|
|
state = adapter_from_ctx(ctx)
|
|
return _dump(
|
|
await asyncio.to_thread(
|
|
_impl.finish_scan,
|
|
executive_summary=executive_summary,
|
|
methodology=methodology,
|
|
technical_analysis=technical_analysis,
|
|
recommendations=recommendations,
|
|
agent_state=state,
|
|
),
|
|
)
|