mirror of
https://github.com/obra/superpowers
synced 2026-07-23 11:04:30 +00:00
Drew Ritter
cdcadda4be
Responds to maintainer review of this branch: the dispatch-hint lines were hardcoded Codex strings inside shared skill tooling that every harness runs. The per-role hint lines now live in a platform-owned data file, skills/using-superpowers/references/codex-dispatch.hints, and the task-brief/review-package scripts only relay the current role's line. The relay is suppressed when CLAUDECODE is set (Claude Code's dispatch templates already carry model selection) and on any harness with no hints file; unknown harnesses fail toward printing, because a silent no-op in the environment that needs the hint is the failure mode this mechanism exists to prevent. Printing at the moment of dispatch is load-bearing: skill text loaded at session start does not survive context compaction, but script output reprints every round. codex-tools.md's SDD dispatch section shrinks to the behavioral rules (fork_turns: "none" always; copy the printed hint verbatim; reviewer tier never exceeds implementer tier; no effort bumps; the <=0.144 inheritance fallback) and points at the hints file for values. Tests cover the relay path, the per-role efforts, and the new CLAUDECODE suppression case. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
82 lines
3.0 KiB
Bash
Executable File
82 lines
3.0 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Generate a review package: commit list, stat summary, and the net
|
|
# diff with extended context, written to a file the reviewer reads in one
|
|
# call. Using the recorded per-task BASE (not HEAD~1) keeps multi-commit
|
|
# tasks intact.
|
|
#
|
|
# Usage: review-package [--role task-review|re-review|final-review] PLAN_FILE BASE HEAD [OUTFILE]
|
|
# Default OUTFILE: <repo-root>/.superpowers/sdd/<plan-basename>/review-<base7>..<head7>.diff
|
|
# (named per range, so a re-review after fixes gets a distinct fresh file).
|
|
#
|
|
# The trailing dispatch hint rides this output because the controller reads it
|
|
# immediately before spawning the reviewer; skill text loaded at session start
|
|
# does not survive context compaction, but this line is reprinted every round.
|
|
set -euo pipefail
|
|
|
|
script_dir=$(cd "$(dirname "$0")" && pwd)
|
|
|
|
role=task-review
|
|
if [ "${1:-}" = "--role" ]; then
|
|
[ $# -ge 2 ] || { echo "usage: review-package [--role task-review|re-review|final-review] PLAN_FILE BASE HEAD [OUTFILE]" >&2; exit 2; }
|
|
role=$2
|
|
shift 2
|
|
fi
|
|
|
|
case "$role" in
|
|
task-review) hint_key=task-review ;;
|
|
# re-review maps onto the fix-review hints entry; the --role value itself
|
|
# is renamed in the next commit.
|
|
re-review) hint_key=fix-review ;;
|
|
final-review) hint_key=final-review ;;
|
|
*) echo "bad --role: ${role} (task-review|re-review|final-review)" >&2; exit 2 ;;
|
|
esac
|
|
|
|
if [ $# -lt 3 ] || [ $# -gt 4 ]; then
|
|
echo "usage: review-package [--role task-review|re-review|final-review] PLAN_FILE BASE HEAD [OUTFILE]" >&2
|
|
exit 2
|
|
fi
|
|
|
|
plan=$1
|
|
base=$2
|
|
head=$3
|
|
[ -f "$plan" ] || { echo "no such plan file: $plan" >&2; exit 2; }
|
|
|
|
git rev-parse --verify --quiet "$base" >/dev/null || { echo "bad BASE: $base" >&2; exit 2; }
|
|
git rev-parse --verify --quiet "$head" >/dev/null || { echo "bad HEAD: $head" >&2; exit 2; }
|
|
|
|
if [ $# -eq 4 ]; then
|
|
out=$4
|
|
else
|
|
dir=$("$script_dir/sdd-workspace" "$plan")
|
|
out="$dir/review-$(git rev-parse --short "$base")..$(git rev-parse --short "$head").diff"
|
|
fi
|
|
|
|
{
|
|
echo "# Review package: ${base}..${head}"
|
|
echo
|
|
echo "## Commits"
|
|
git log --oneline "${base}..${head}"
|
|
echo
|
|
echo "## Files changed"
|
|
git diff --stat "${base}..${head}"
|
|
echo
|
|
echo "## Diff"
|
|
git diff -U10 "${base}..${head}"
|
|
} > "$out"
|
|
|
|
commits=$(git rev-list --count "${base}..${head}")
|
|
echo "wrote ${out}: ${commits} commit(s), $(wc -c < "$out" | tr -d ' ') bytes"
|
|
|
|
# Platform dispatch hints ride this output because the controller reads it
|
|
# immediately before spawning; the lines themselves are owned by the platform
|
|
# reference layer (using-superpowers/references/*-dispatch.hints), not this
|
|
# script. Claude Code's dispatch templates carry model selection already, so
|
|
# the relay is suppressed there and on any harness without a hints file.
|
|
hints_file="$script_dir/../../using-superpowers/references/codex-dispatch.hints"
|
|
if [ -z "${CLAUDECODE:-}" ] && [ -f "$hints_file" ]; then
|
|
hint_line=$(grep "^${hint_key}:" "$hints_file" | head -1 | cut -d: -f2- | sed 's/^ *//') || true
|
|
if [ -n "$hint_line" ]; then
|
|
echo "$hint_line"
|
|
fi
|
|
fi
|