Jesse Vincent deb9d855cb fix(skills): close the change-detector hole in writing-good-tests ...

Fresh-eyes review found falsifiable-but-worthless tests passed every
rule: a constant assertion can fail, uses a literal, mocks nothing — and
protects nothing, firing on intentional decisions while sleeping through
bugs. Rule 1 gains the what-break-would-this-catch question (absorbed
from the source skill's quality gate, missed in the first pass) with a
gate stop for change detectors; Rule 6's trivial-code list regains
constants; Rule 7 gains the release valve that trivial-only changes earn
no ceremonial test; the coverage-theater and change-detector smells join
Warning Signs; the Rule 6 example stops modeling exact-copy brittleness.
Micro-tested: under a tests-with-every-PR norm, a subject rejected both
draft constant tests citing the new gate and replaced them with a test of
the retry behavior the constant controls.

2026-07-05 13:03:35 -07:00

..

SKILL.md

feat(skills): absorb falsifiability discipline into writing-good-tests

2026-07-05 12:59:56 -07:00

writing-good-tests.md

fix(skills): close the change-detector hole in writing-good-tests

2026-07-05 13:03:35 -07:00